Skip to content

fix(nullattributes): track and activate should not remove null attributes. #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 24, 2018
Merged

fix(nullattributes): track and activate should not remove null attributes. #168

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
649962b
Add attribute types support.
mfahadahmed Sep 18, 2018
402f8e8
Add unit tests for attribute types support and event payload attribut…
mfahadahmed Sep 19, 2018
68db7de
Attribute validation for log-tier
msohailhussain Sep 20, 2018
35095e0
Merge remote-tracking branch 'origin/fahad/attribute-types' into faha…
mfahadahmed Sep 21, 2018
0ee73f1
Remove attributes null value check.
mfahadahmed Sep 21, 2018
77b4023
indented correctly.
msohailhussain Sep 21, 2018
03c5c57
activate shouldn't filter attributes for notification listener
msohailhussain Sep 21, 2018
30472a3
activate/track shouldn't filter attributes for notification listener
msohailhussain Sep 21, 2018
81f2ad6
Merge branch 'master' into sohail/activatenullvalues
mikeproeng37 Sep 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions packages/optimizely-sdk/lib/optimizely/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,7 @@ Optimizely.prototype.activate = function (experimentKey, userId, attributes) {
this.logger.log(LOG_LEVEL.DEBUG, shouldNotDispatchActivateLogMessage);
return variationKey;
}

// remove null values from attributes
attributes = this.__filterEmptyValues(attributes);


this._sendImpressionEvent(experimentKey, variationKey, userId, attributes);

return variationKey;
Expand Down Expand Up @@ -238,8 +235,7 @@ Optimizely.prototype.track = function(eventKey, userId, attributes, eventTags) {
return;
}

// remove null values from attributes and eventTags
attributes = this.__filterEmptyValues(attributes);
// remove null values from eventTags
eventTags = this.__filterEmptyValues(eventTags);

var conversionEventOptions = {
Expand Down