feat(eventbuilder): Track attributes with valid attribute types #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msohailhussain
commented
Sep 21, 2018
| @@ -43,4 +45,8 @@ module.exports = { | |||
| throw new Error(sprintf(ERROR_MESSAGES.INVALID_ATTRIBUTES, MODULE_NAME)); | |||
| } | |||
| }, | |||
|
|
|||
| isAttributeValid: function(attributeKey, attributeValue) { | |||
There was a problem hiding this comment.
need to update attribute value 'null' shouldn't be sent to logtier.
mjc1283
suggested changes
Sep 21, 2018
| type: CUSTOM_ATTRIBUTE_FEATURE_TYPE, | ||
| value: attributes[attributeKey], | ||
| }); | ||
| } |
There was a problem hiding this comment.
Should we log a message if isAttributeValid returns false?
There was a problem hiding this comment.
I think not, because attributes are omitted for log tier, nothing to deal at user side. User will get all attributes. it will be confusing if logtier message is logged.
| key: "integer_key" | ||
| }, { | ||
| id: "808797686", | ||
| key: "double_key" |
There was a problem hiding this comment.
Nit: can we fix the indentation?
mjc1283
approved these changes
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.