Skip to content

fix(logs): Change invalid experiment key to debug level. #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2018

Conversation

mikeproeng37
Copy link
Contributor

Summary

Change the log level from ERROR to DEBUG when we are not able to find the experiment with the given key in the datafile. The reason is because we stopped including non-active experiments in the datafile so if you reference an inexistent experiment, it could mean that the experiment is paused/archived as opposed to existing at all in your project.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 97.065% when pulling 9c439ba on mng/change-invalid-exp-loglvl into 0d263fc on master.

Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikeproeng37 mikeproeng37 merged commit feb34eb into master Sep 20, 2018
@mikeproeng37 mikeproeng37 deleted the mng/change-invalid-exp-loglvl branch September 21, 2018 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants