chore(release): bump to 2.1.3. #156
Conversation
mikeproeng37
changed the title
mikeproeng37
requested review from
spencerwilson-optimizely,
tylerbrandt and
aliabbasrizvi
|
build-e2e |
There was a problem hiding this comment.
I'm not sure if a "deprecation" should make something go from a semver-PATCH to semver-MINOR release, but my comments assume it does (on the principle that a release is a patch release if and only if its changelog entry only contains Fixed items. It's a debatable definition for sure...)
Mentally replace "2.2.0" in the comments with "2.1.3" if you disagree. I don't feel strongly about it right now, but at some point we should align on it.
| @@ -9,6 +9,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
| ### Deprecated | |||
There was a problem hiding this comment.
Please move the stuff under Unreleased into the new 2.2.0 entry.
packages/optimizely-sdk/CHANGELOG.MD
Outdated
| @@ -9,6 +9,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
| ### Deprecated | |||
| * The UMD build of the SDK now assigns the SDK namespace object to `window.optimizelySdk` rather than to `window.optimizelyClient`. The old name still works, but on its first access a deprecation warning is logged to the console. The alias will be removed in the 3.0.0 release. | |||
|
|
|||
| ## [2.1.2] - August 21, 2018 | |||
There was a problem hiding this comment.
I think this release is 2.2.0. The current release on npm is 2.1.2.
There was a problem hiding this comment.
:( this means the current production package is sending the wrong version. Nice catch though. I'd argue for 2.1.3 because we aren't introducing any new features, at least that's what we've been using as a basis for minor version bumps.
There was a problem hiding this comment.
I think I bumped the version in v2.1.x branch only (#126), since that's the only place the patch version is relevant.
There was a problem hiding this comment.
Does that mean that the changelog entry for 2.1.2 never escapes the v2.1.x branch? That's not good :\
There was a problem hiding this comment.
The changelog is correct/complete on all released tags, at least (none of which are defined in master). I can see the argument for keeping master up-to-date with the "current" branch though, so we can change it.
mikeproeng37
changed the title
packages/optimizely-sdk/CHANGELOG.MD
Outdated
| ### Deprecated | ||
| * The UMD build of the SDK now assigns the SDK namespace object to `window.optimizelySdk` rather than to `window.optimizelyClient`. The old name still works, but on its first access a deprecation warning is logged to the console. The alias will be removed in the 3.0.0 release. | ||
| - The UMD build of the SDK now assigns the SDK namespace object to `window.optimizelySdk` rather than to `window.optimizelyClient`. The old name still works, but on its first access a deprecation warning is logged to the console. The alias will be removed in the 3.0.0 release. |
There was a problem hiding this comment.
nit: could you add the link to the PR like for the others? (I shoulda done this but wasn't aware of the pattern, but I like it)
There was a problem hiding this comment.
duh, yeah I shoulda added it, will do
Summary