chore(package): Delete unused build scripts #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeproeng37
approved these changes
Jun 29, 2018
This was referenced Jun 29, 2018
spencerwilson-optimizely
added a commit
that referenced
this pull request
Jul 3, 2018
## Summary - Add the same Full Stack description to the top of the READMEs here that @jonslaught advised to for python-sdk in optimizely/python-sdk#124 - Clarify Lerna usage: no multiple packages, for now - Fix stale package name in root readme, and fix the NPM badge that also was based on it - Add badges to `@optimizely/optimizely-sdk`'s README - Precisely document supported JavaScript environments - Add note about default `EventDispatcher`s. (I have mixed feelings on this; happy to hear opinions) - Make `Contributing` section more concise - Drop references to `dist/` artifacts, since #135 made them no longer a thing [Rendered](https://github.com/optimizely/javascript-sdk/blob/sw/readme/packages/optimizely-sdk/README.md)
spencerwilson-optimizely
added a commit
that referenced
this pull request
Aug 20, 2018
## Summary - Restore the `build-browser-umd` npm script, which produces dist/optimizely.browser.umd.min.js - Change the UMD lib name `optimizelyClient` -> `optimizelySdk`, since the `createInstance` client factory function may be one of several exports of the SDK, in the future. - (not a visible change) Change Markdown indentation of some bull points, to please my Markdown editor [Typora](https://typora.io/) This undoes one bit of #135. I hadn't realized that this asset _was_ documented, and does have some uses, like faster/easier prototyping in a browser. ## Test plan I made a foo.html with ```html <html> <head> <script src="./dist/optimizely.browser.umd.min.js"></script> <script> console.log('trying sdk'); window.optimizelySdk console.log('trying client'); window.optimizelyClient console.log('trying client'); window.optimizelyClient </script> </head> </html> ``` and it still works: 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #133, we're no longer distributing an already-bundled package. With that change, I don't think there are any consumers of these 'build' run-scripts.