Skip to content

[FSSDK-9127] fix: Handle ODP INVALID_IDENTIFIER_EXCEPTION code #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 3, 2023

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented May 2, 2023

Summary

Support a new format for ODP InvalidIdentifierException (when SDK fetches segments with a non-registered userId).

       "extensions": {
            "code": "INVALID_IDENTIFIER_EXCEPTION",
            "classification": "DataFetchingException"
       }

Test plan

  • updated unit tests to cover the new response format.
  • Existing unit tests should pass
  • FSC should continue to pass

Issues

  • FSSDK-9127

@mnoman09 mnoman09 changed the title [FSSDK-9127] Fix: Verifiying that ODP INVALID_IDENTIFIER_EXCEPTION code is handled gracefully. [FSSDK-9127] fix: Handle ODP INVALID_IDENTIFIER_EXCEPTION code May 3, 2023
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, it's quite expensive to support it in java-sdk. I see a couple of more cases to be covered.

@mnoman09 mnoman09 requested a review from jaeopt May 3, 2023 21:55
@mnoman09 mnoman09 removed their assignment May 3, 2023
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnoman09 mnoman09 merged commit 562310f into master May 3, 2023
@mnoman09 mnoman09 deleted the mnoman/invalid-identifier branch May 3, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants