-
Notifications
You must be signed in to change notification settings - Fork 32
feat: Integrated ODPManager with UserContext and Optimizely client #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
525ad99
5d3cb21
0a1bf21
0c74a18
42b2425
79263fc
e573a6a
6d88b86
68aa5ff
29f2b09
49a9686
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,7 @@ | |
import javax.annotation.Nullable; | ||
import java.util.List; | ||
import java.util.Map; | ||
import java.util.Set; | ||
|
||
/** | ||
* ProjectConfig is an interface capturing the experiment, variation and feature definitions. | ||
|
@@ -69,6 +70,8 @@ Experiment getExperimentForKey(@Nonnull String experimentKey, | |
|
||
List<Experiment> getExperiments(); | ||
|
||
Set<String> getAllSegments(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wondering if this addition to the interface will require changes to all existing customization. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If users are using their own ProjectConfigManagers? yes! But this is the only way to add more functionality to ProjectConfig. I believe almost no one will be customizing the whole ProjectConfigManager. If there are a handful of customers who are even doing it, ATS will go out as a major version change anyway. We can mention this in the release notes as a breaking change. What do you think? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @zashraf1985 We'll go for a major version change if we have to. We better keep all the breaking changes required. |
||
|
||
List<Experiment> getExperimentsForEventKey(String eventKey); | ||
|
||
List<FeatureFlag> getFeatureFlags(); | ||
|
Uh oh!
There was an error while loading. Please reload this page.