Skip to content

Updating doc urls #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Updating doc urls #471

merged 2 commits into from
Apr 7, 2022

Conversation

trishahanlon
Copy link
Collaborator

Summary

Updating the URLs to the Java SDK documentation.

Test plan

Issues

@coveralls
Copy link

coveralls commented Apr 6, 2022

Pull Request Test Coverage Report for Build 1983

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.806%

Totals Coverage Status
Change from base Build 1970: 0.0%
Covered Lines: 4889
Relevant Lines: 5384

💛 - Coveralls

@jaeopt
Copy link
Contributor

jaeopt commented Apr 7, 2022

@trishahanlon It looks good. A question is why not using 4.0 link instead of 3.1.0?

@trishahanlon
Copy link
Collaborator Author

@jaeopt There is no corresponding rollouts documentation in v4.0 of the docs. So, I left that URL to point to v3.1, but I have updated the other links to go to v4.0. Thanks.

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trishahanlon trishahanlon merged commit 9dc9089 into master Apr 7, 2022
@trishahanlon trishahanlon deleted the trishahanlon-update-docs-urls branch April 7, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollouts documentation does not exists
3 participants