Skip to content

fix:update OptimizelyDecisionContext to check null for flagKey #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2021
Merged

fix:update OptimizelyDecisionContext to check null for flagKey #455

merged 1 commit into from
Dec 7, 2021

Conversation

The-inside-man
Copy link
Contributor

Summary

  • Add null check to OptimizelyDecisionContext constructor for flagKey

We want to confirm the user is not passing a null value as flagKey in addition to the @nonnull annotation provided to ensure the object is valid

Test plan

  • FSC

Issues

N/A

@coveralls
Copy link

coveralls commented Dec 6, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1909

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 90.733%
Totals Coverage Status
Change from base Build 1908: 0.002%
Covered Lines: 4866
Relevant Lines: 5363
💛 - Coveralls

@The-inside-man The-inside-man marked this pull request as ready for review December 6, 2021 20:17
@The-inside-man The-inside-man requested a review from a team as a code owner December 6, 2021 20:17
jaeopt
jaeopt approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@The-inside-man The-inside-man merged commit 7eb639c into master Dec 7, 2021
@The-inside-man The-inside-man deleted the jbrown/update-fd-nullcheck branch December 7, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@The-inside-man The-inside-man

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@The-inside-man @coveralls @jaeopt