Skip to content

Update conditions to use StringBuilder instead of StringJoiner #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 23, 2021
Merged

Update conditions to use StringBuilder instead of StringJoiner #443

merged 6 commits into from
Aug 23, 2021

Conversation

The-inside-man
Copy link
Contributor

@The-inside-man The-inside-man commented Aug 23, 2021 •
edited
Loading

Summary

  • Changing StringJoiner to StringBuilder for compatibility with Android
  • Additional test cases for coverage and to verify json format of condition string

Android does not support StringJoiner at this time

Test plan

FSC and Unit Tests locally

Issues

  • N/A

@The-inside-man The-inside-man requested a review from a team as a code owner August 23, 2021 12:15
@coveralls
Copy link

coveralls commented Aug 23, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1817

  • 16 of 16 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 90.51%
Totals Coverage Status
Change from base Build 1810: 0.1%
Covered Lines: 4721
Relevant Lines: 5216
💛 - Coveralls

@The-inside-man The-inside-man marked this pull request as draft August 23, 2021 12:35
@The-inside-man The-inside-man removed the request for review from a team August 23, 2021 12:35
@The-inside-man The-inside-man removed their assignment Aug 23, 2021
@The-inside-man The-inside-man marked this pull request as ready for review August 23, 2021 14:24
@The-inside-man The-inside-man requested review from jaeopt and a team August 23, 2021 14:25
jaeopt
jaeopt approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 5de0a7b into master Aug 23, 2021
@jaeopt jaeopt deleted the jbrown/update-stringjoiner branch August 23, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@The-inside-man @coveralls @jaeopt