Skip to content

chore: migrate upload repository to maven-central from jcenter #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 1, 2021
Merged

chore: migrate upload repository to maven-central from jcenter #424

merged 4 commits into from
Mar 1, 2021

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Feb 27, 2021 •
edited
Loading

@jaeopt jaeopt requested a review from a team as a code owner February 27, 2021 00:08
@jaeopt jaeopt removed their assignment Feb 27, 2021
@coveralls
Copy link

coveralls commented Feb 27, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1673

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 90.351%
Totals Coverage Status
Change from base Build 1671: 0.4%
Covered Lines: 4457
Relevant Lines: 4933
💛 - Coveralls

mnoman09
mnoman09 reviewed Mar 1, 2021
View reviewed changes
Copy link
Contributor

@mnoman09 mnoman09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Local build signing is failing, I think it should be conditional.

@msohailhussain msohailhussain self-requested a review March 1, 2021 22:18
msohailhussain
msohailhussain approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaeopt jaeopt merged commit 3527724 into master Mar 1, 2021
@jaeopt jaeopt deleted the jae/maven-central branch March 1, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnoman09 mnoman09 mnoman09 left review comments

@msohailhussain msohailhussain msohailhussain approved these changes

Assignees
No one assigned
Labels
🤖 4 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaeopt @coveralls @msohailhussain @mnoman09 @optimizely-codereview-bot