Skip to content

Fix: GetVariationForFeatureInRollout to return null decisionResponse when rolloutRulesLength is zero #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2021
Merged

Fix: GetVariationForFeatureInRollout to return null decisionResponse when rolloutRulesLength is zero #423

merged 1 commit into from
Feb 25, 2021

Conversation

mnoman09
Copy link
Contributor

Summary

  • GetVariationForFeatureInRollout to return null decisionResponse when rolloutRulesLength is zero

@mnoman09 mnoman09 requested a review from a team as a code owner February 15, 2021 14:31
@mnoman09 mnoman09 changed the title Feat: GetVariationForFeatureInRollout to return null decisionResponse when rolloutRulesLength is zero Fix: GetVariationForFeatureInRollout to return null decisionResponse when rolloutRulesLength is zero Feb 15, 2021
@coveralls
Copy link

coveralls commented Feb 15, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1668

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 89.931%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core-api/src/main/java/com/optimizely/ab/bucketing/DecisionService.java 1 2 50.0%
Totals Coverage Status
Change from base Build 1664: -0.02%
Covered Lines: 4457
Relevant Lines: 4956
💛 - Coveralls

jaeopt
jaeopt approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@mnoman09 What is the implication of this fix? Is this a bug fix that need be released immediately or just for FSC testing support?

@mnoman09
Copy link
Contributor Author

LGTM
@mnoman09 What is the implication of this fix? Is this a bug fix that need be released immediately or just for FSC testing support?

This is a bug fix. It was causing an exception on line 37 of array index out of bound in case of rollout length is zero.

@jaeopt jaeopt merged commit b253f47 into master Feb 25, 2021
@jaeopt jaeopt deleted the mnoman/fixRolloutExperimentEmpty branch February 25, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@mnoman09 mnoman09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnoman09 @coveralls @jaeopt