Skip to content

feat: add "json" type to FeatureVariable #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 1, 2020
Merged

feat: add "json" type to FeatureVariable #372

merged 6 commits into from
May 1, 2020

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Apr 22, 2020

Summary

  • Add "json" type to FeatureVariable
  • Add "string" + "json" subtype for backward compatibility

Test plan

  • Verify that subtype is converted to json type internally
  • Verify that the new data type does not crash SDK

@jaeopt jaeopt requested a review from a team as a code owner April 22, 2020 23:45
@jaeopt jaeopt changed the title feature: add "json" type to FeatureVariable feat: add "json" type to FeatureVariable Apr 22, 2020
@coveralls
Copy link

coveralls commented May 1, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1386

  • 9 of 11 (81.82%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 89.315%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core-api/src/main/java/com/optimizely/ab/config/FeatureVariable.java 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
core-api/src/main/java/com/optimizely/ab/config/FeatureVariable.java 1 71.43%
Totals Coverage Status
Change from base Build 1380: -0.006%
Covered Lines: 3770
Relevant Lines: 4221
💛 - Coveralls

@jaeopt jaeopt requested a review from mikecdavis May 1, 2020 00:56
mikecdavis
mikecdavis approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@mikecdavis mikecdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pawels-optimizely
pawels-optimizely approved these changes May 1, 2020
View reviewed changes
Copy link

@pawels-optimizely pawels-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaeopt jaeopt merged commit b08b7a5 into master May 1, 2020
@jaeopt jaeopt deleted the jae/json-type branch May 1, 2020 21:31
jaeopt added a commit that referenced this pull request May 4, 2020
@jaeopt
feat: add "json" type to FeatureVariable (#372)
effd75d
This was referenced Jul 2, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecdavis mikecdavis mikecdavis approved these changes

@pawels-optimizely pawels-optimizely pawels-optimizely approved these changes

@thomaszurkan-optimizely thomaszurkan-optimizely Awaiting requested review from thomaszurkan-optimizely

Assignees

@jaeopt jaeopt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaeopt @coveralls @mikecdavis @pawels-optimizely