Skip to content

fix: change FeatureVariable type to string for forward compatibility #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2020
Merged

fix: change FeatureVariable type to string for forward compatibility #370

merged 2 commits into from
Apr 22, 2020

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Apr 15, 2020

Summary

  • FeatureVariable Type was Enum with fixed types, which does not support future types (JSON, etc).
  • Change the type to String for forward compatibility

Test plan

  • Add a variable with undefined type name and make sure SDK does not crash

@jaeopt jaeopt requested a review from a team as a code owner April 15, 2020 22:18
@coveralls
Copy link

coveralls commented Apr 15, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1372

  • 6 of 7 (85.71%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 89.321%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core-api/src/main/java/com/optimizely/ab/Optimizely.java 0 1 0.0%
Totals Coverage Status
Change from base Build 1367: -0.03%
Covered Lines: 3764
Relevant Lines: 4214
💛 - Coveralls

thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 3458198 into master Apr 22, 2020
@jaeopt jaeopt deleted the jae/variable-enum branch April 22, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

@mikecdavis mikecdavis Awaiting requested review from mikecdavis

Assignees

@jaeopt jaeopt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaeopt @coveralls @thomaszurkan-optimizely