Properly set logger name for AudienceIdCondition and ConditionUtils #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1339
💛 - Coveralls |
gcampfield
changed the title
|
Hi @gcampfield, Thanks for submitting this fix. Would you please sign our CLA as described here: https://github.com/optimizely/java-sdk/blob/master/CONTRIBUTING.md#contributing-to-the-optimizely-java-sdk? After that, we are happy to merge this PR. |
|
I've signed the CLA. Thanks, @mjc1283 ! |
mjc1283
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Logger name for
AudienceIdCondition.javais currently just the static string "AudienceIdCondition". This means that it's not possible to change the log level of this class using thecom.optimizelygroup.This should be changed to use the class
AudienceIdCondition.classitself.