Skip to content

Update HttpProjectConfigManager to use Last-Modified time #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 4, 2019

Conversation

aliabbasrizvi
Copy link
Contributor

Summary

We now store and use the Last-Modified time when requesting the datafile. In all requests If-Modified-Since header is set and HttpProjectConfigManager creates new project config if there is a HTTP 200 response.

@aliabbasrizvi aliabbasrizvi requested a review from mikecdavis May 3, 2019 23:02
Copy link
Contributor

@mikecdavis mikecdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1014

  • 16 of 22 (72.73%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 89.056%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-httpclient-impl/src/main/java/com/optimizely/ab/OptimizelyHttpClient.java 0 1 0.0%
core-httpclient-impl/src/main/java/com/optimizely/ab/config/HttpProjectConfigManager.java 16 21 76.19%
Files with Coverage Reduction New Missed Lines %
core-httpclient-impl/src/main/java/com/optimizely/ab/config/HttpProjectConfigManager.java 7 65.82%
Totals Coverage Status
Change from base Build 1012: -0.3%
Covered Lines: 3084
Relevant Lines: 3463

💛 - Coveralls

@coveralls
Copy link

coveralls commented May 4, 2019

Pull Request Test Coverage Report for Build 1019

  • 16 of 22 (72.73%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 89.056%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-httpclient-impl/src/main/java/com/optimizely/ab/OptimizelyHttpClient.java 0 1 0.0%
core-httpclient-impl/src/main/java/com/optimizely/ab/config/HttpProjectConfigManager.java 16 21 76.19%
Files with Coverage Reduction New Missed Lines %
core-httpclient-impl/src/main/java/com/optimizely/ab/config/HttpProjectConfigManager.java 7 65.82%
Totals Coverage Status
Change from base Build 1012: -0.3%
Covered Lines: 3084
Relevant Lines: 3463

💛 - Coveralls

@aliabbasrizvi aliabbasrizvi force-pushed the ali/implement_if_modified branch from b0323c4 to 01ab857 Compare May 4, 2019 16:00
@aliabbasrizvi aliabbasrizvi merged commit 543c1c2 into master May 4, 2019
@aliabbasrizvi aliabbasrizvi deleted the ali/implement_if_modified branch May 4, 2019 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants