Skip to content

Adding toString for DecisionNotification #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 3, 2019
Merged

Adding toString for DecisionNotification #291

merged 3 commits into from
May 3, 2019

Conversation

aliabbasrizvi
Copy link
Contributor

  • Adding toString in DecisionNotification. Also, added relevant test.
  • Fixed notification listener builder as well to use toString of VariableType.

@coveralls
Copy link

coveralls commented May 3, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1011

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.33%
Totals Coverage Status
Change from base Build 1010: 0.02%
Covered Lines: 3081
Relevant Lines: 3449
💛 - Coveralls

@aliabbasrizvi aliabbasrizvi requested a review from mikeproeng37 May 3, 2019 17:58
mikecdavis
mikecdavis approved these changes May 3, 2019
View reviewed changes
Copy link
Contributor

@mikecdavis mikecdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aliabbasrizvi aliabbasrizvi merged commit 73a9d88 into master May 3, 2019
@aliabbasrizvi aliabbasrizvi deleted the ali/add_decision_to_string branch May 3, 2019 22:46
aliabbasrizvi added a commit that referenced this pull request May 3, 2019
@aliabbasrizvi
Adding toString for DecisionNotification (#291)
06ab535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecdavis mikecdavis mikecdavis approved these changes

@msohailhussain msohailhussain Awaiting requested review from msohailhussain

@mikeproeng37 mikeproeng37 Awaiting requested review from mikeproeng37

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aliabbasrizvi @coveralls @mikecdavis