Skip to content

fix(number validation): Don't track NaN, Infinity, -Infinity, or > 2^53 #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 25, 2019
Merged
Prev Previous commit
Next Next commit
Updated headers
  • Loading branch information
mnoman09 committed Jan 2, 2019
commit 18d54d396d3915c7d9ced1f79ef6e8c5501389f3
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
*
* Copyright 2018, Optimizely and contributors
* Copyright 2018-2019, Optimizely and contributors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
*
* Copyright 2016-2018, Optimizely and contributors
* Copyright 2016-2019, Optimizely and contributors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,20 @@
/**
*
* Copyright 2019, Optimizely and contributors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.optimizely.ab.internal;

public class AttributesUtil {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
*
* Copyright 2016-2018, Optimizely and contributors
* Copyright 2016-2019, Optimizely and contributors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -340,7 +340,7 @@ public void createConversionEventIgnoresInvalidAndAcceptsValidAttributes() {
* causing an exception to be thrown and passing only the valid attributes.
*/
@Test
public void createConversionEventIgnoresInvalidAndAcceptsValidValueOfValidTypeAttributes() {
public void createConversionEventIgnoresInvalidAcceptValidValOfValidAttr() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you will have to adjust this test to accommodate changes from: #250

The expectation is that there will be no decisions and enrich_decisions should be set to true

assumeTrue(datafileVersion >= Integer.parseInt(ProjectConfig.Version.V4.toString()));

Bucketer mockBucketAlgorithm = mock(Bucketer.class);
Expand Down