Skip to content

(choir) update for latest RC #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2018
Merged

(choir) update for latest RC #238

merged 1 commit into from
Nov 20, 2018

Conversation

thomaszurkan-optimizely
Copy link
Contributor

Summary

  • Update the 3.0.0 rc.
    • This includes a graceful shutdown method for AsyncEventHandler.
    • This also includes json parsing for leaf nodes in condition trees.

Test plan

Issues

@coveralls
Copy link

coveralls commented Nov 20, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 764

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.746%
Totals Coverage Status
Change from base Build 763: 0.0%
Covered Lines: 2687
Relevant Lines: 2994
💛 - Coveralls

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit cb7fa98 into master Nov 20, 2018
@aliabbasrizvi aliabbasrizvi deleted the updateFor3.0.0RC2 branch October 1, 2019 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjc1283 mjc1283 mjc1283 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomaszurkan-optimizely @coveralls @mjc1283