fix(number validation): Don't target NaN, Infinity, -Infinity, or > 2^53 #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchilada
approved these changes
Oct 16, 2018
| @Test | ||
| public void gtMatchConditionEvaluatesNullWithInvalidAttr() throws Exception { | ||
| BigInteger bigInteger = new BigInteger("33221312312312312"); | ||
| Double infiniteDouble = 1.2/0; |
There was a problem hiding this comment.
Technically this evaluates to NaN, not infinity. It's probably cleaner use Double.NaN, Double.POSITIVE_INFINITY, and Double.NEGATIVE_INFINITY where needed
| @@ -72,6 +70,16 @@ else if (conditionValue instanceof Boolean) { | |||
| return new MatchType(matchType, new NullMatch()); | |||
| } | |||
|
|
|||
| private static boolean isValidNumber(Object conditionValue) { | |||
| if (conditionValue instanceof Integer || conditionValue instanceof Double) { | |||
There was a problem hiding this comment.
If conditionValue instanceof Integer, can we also add a restriction that Math.abs(value) <= 1e53? Technically it's unnecessary since Java ints can't be that large, but since this is a reference SDK, it might be helpful to set an example for other SDKs.
Pull Request Test Coverage Report for Build 722
💛 - Coveralls |
…assertions to check infinite and NAN double
|
@msohailhussain do you know when you might be able to merge this? @mikeng13 it might be nice to get this into the first official 3.0 release. |
loganlinn
reviewed
Oct 30, 2018
| return true; | ||
| } else if (conditionValue instanceof Double) { | ||
| Double value = ((Number) conditionValue).doubleValue(); | ||
| if (value.isNaN() || value.isInfinite()) { |
There was a problem hiding this comment.
Suggested change
| if (value.isNaN() || value.isInfinite()) { | |
| return !(value.isNaN() || value.isInfinite()); |
| @@ -72,6 +70,21 @@ else if (conditionValue instanceof Boolean) { | |||
| return new MatchType(matchType, new NullMatch()); | |||
| } | |||
|
|
|||
| private static boolean isValidNumber(Object conditionValue) { | |||
| if (conditionValue instanceof Integer) { | |||
| if (Math.abs((Integer) conditionValue) > 1e53) { | |||
There was a problem hiding this comment.
Suggested change
| if (Math.abs((Integer) conditionValue) > 1e53) { | |
| return Math.abs((Integer) conditionValue) <= 1e53; |
nchilada
changed the title
nchilada
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.