Skip to content

fix(nullfilter): Filters attributes in getFeatureVariableValueForType #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mnoman09
Copy link
Contributor

Filters attributes getFeatureVariableValueForType before passing it to decisionService.getVariationForFeature So if attributes passed is null than it will handle it.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 611

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 88.976%

Totals Coverage Status
Change from base Build 606: 0.004%
Covered Lines: 2381
Relevant Lines: 2676

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 611

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 88.976%

Totals Coverage Status
Change from base Build 606: 0.004%
Covered Lines: 2381
Relevant Lines: 2676

💛 - Coveralls

@msohailhussain msohailhussain changed the title Filters attributes in getFeatureVariableValueForType fix(nullfilter): Filters attributes in getFeatureVariableValueForType Sep 10, 2018
@mikeproeng37
Copy link
Contributor

Closing this as well as it is taken care of in #214

@mikeproeng37 mikeproeng37 deleted the mnoman/filterAttrOnFeatVarType branch September 21, 2018 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants