Skip to content

style: rename custom dimensions as custom attributes #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 6, 2018
Merged

style: rename custom dimensions as custom attributes #210

merged 2 commits into from
Sep 6, 2018

Conversation

shihpatrick
Copy link
Contributor

Renamed custom dimensions to custom attributes in >=v2 related files to be consistent with our current datafiles.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 604

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.972%
Totals Coverage Status
Change from base Build 603: 0.0%
Covered Lines: 2380
Relevant Lines: 2675
💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 6, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 605

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.972%
Totals Coverage Status
Change from base Build 603: 0.0%
Covered Lines: 2380
Relevant Lines: 2675
💛 - Coveralls

mikeproeng37
mikeproeng37 approved these changes Sep 6, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shihpatrick shihpatrick merged commit 1abfbb7 into master Sep 6, 2018
@mikeproeng37 mikeproeng37 deleted the pshih/dimension-to-attribute branch September 21, 2018 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@thomaszurkan-optimizely thomaszurkan-optimizely Awaiting requested review from thomaszurkan-optimizely

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shihpatrick @coveralls @mikeproeng37 @patrickshih-optimizely