Skip to content

Fix impression sent from feature experiment variation toggled off. #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2018
Merged

Fix impression sent from feature experiment variation toggled off. #193

merged 1 commit into from
Jun 19, 2018

Conversation

mikeproeng37
Copy link
Contributor

No description provided.

@tylerbrandt
Copy link
Contributor

build

@tylerbrandt
Copy link
Contributor

updated compat suite branch

@coveralls
Copy link

coveralls commented Jun 19, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 537

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 89.049%
Totals Coverage Status
Change from base Build 534: 0.004%
Covered Lines: 2220
Relevant Lines: 2493
💛 - Coveralls

aliabbasrizvi
aliabbasrizvi approved these changes Jun 19, 2018
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

core-api/src/test/java/com/optimizely/ab/OptimizelyTest.java
* Verify {@link Optimizely#isFeatureEnabled(String, String)} calls into
* {@link Optimizely#isFeatureEnabled(String, String, Map)} and they both
* return False
* when the user is bucketed an feature test variation that is turned off.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in and not an

@mikeproeng37
Copy link
Contributor Author

build

3 similar comments
@mikeproeng37
Copy link
Contributor Author

build

@mikeproeng37
Copy link
Contributor Author

build

@tylerbrandt
Copy link
Contributor

build

@mikeproeng37 mikeproeng37 merged commit f5b9516 into master Jun 19, 2018
tylerbrandt pushed a commit that referenced this pull request Jun 19, 2018
@mikeproeng37
Fix impression sent from feature experiment variation toggled off. (#193
e9588e8 
)
tylerbrandt pushed a commit that referenced this pull request Jun 19, 2018
@mikeproeng37
Fix impression sent from feature experiment variation toggled off. (#193
47543c6 
)
tylerbrandt pushed a commit that referenced this pull request Jun 19, 2018
chore: release 2.1.1 (#195)
370a8e8 
* Fix impression sent from feature experiment variation toggled off. (#193)
tylerbrandt pushed a commit that referenced this pull request Jun 19, 2018
chore: release 2.0.2 (#194)
5dbee7e 
* Fix impression sent from feature experiment variation toggled off. (#193)
@aliabbasrizvi aliabbasrizvi deleted the mng/fix-feature-exp-impression branch August 10, 2018 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikeproeng37 @tylerbrandt @coveralls @aliabbasrizvi