Skip to content

ignore experiment status when bucketing rollout rule experiments #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wangjoshuah
Copy link
Contributor

we do not need to check experiment status since the datafile will not have inactive experiments

@wangjoshuah wangjoshuah requested a review from a team September 12, 2017 21:08
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. but, i have to ask, is it really a good idea to include someone in a rollout that is not active?

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wangjoshuah
Copy link
Contributor Author

@thomaszurkan-optimizely The rollout rule experiment will be filtered out if not active by the datafile.

@wangjoshuah wangjoshuah merged commit 6baf16f into master Sep 12, 2017
@wangjoshuah wangjoshuah deleted the josh.wang/rollout-bucketing-ignores-experiment-status branch September 12, 2017 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants