-
Notifications
You must be signed in to change notification settings - Fork 32
internal feature variable accessor support #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wangjoshuah
merged 14 commits into
master
from
josh.wang/feature_variable_accessor_with_type
Aug 8, 2017
Merged
internal feature variable accessor support #131
wangjoshuah
merged 14 commits into
master
from
josh.wang/feature_variable_accessor_with_type
Aug 8, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not found for key add test for featureVariableString accessor returns null when variable not found for key
…riment add test for getFeatureVariableString returns default value when the feature is not attached to an experiment Signed-off-by: wangjoshuah <wangjoshuah@gmail.com>
test default value is return when user is excluded from the single experiment due to targeting Signed-off-by: wangjoshuah <wangjoshuah@gmail.com>
… called with a feature without attached experiments
…s not bucketed into any experiments
…ucketed into when there are multiple experiments
…nstead of the string method. test all cases
@optimizely/fullstack-devs |
mikeproeng37
approved these changes
Aug 8, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Feature Variable Accessor with type support
Create internal Decision Service method for features