Skip to content

internal feature variable accessor support #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 8, 2017

Conversation

wangjoshuah
Copy link
Contributor

Create Feature Variable Accessor with type support
Create internal Decision Service method for features

… not found for key

add test for featureVariableString accessor returns null when variable not found for key
…riment

add test for getFeatureVariableString returns default value when the feature is not attached to an experiment

Signed-off-by: wangjoshuah <wangjoshuah@gmail.com>
test default value is return when user is excluded from the single experiment due to targeting

Signed-off-by: wangjoshuah <wangjoshuah@gmail.com>
… called with a feature without attached experiments
…ucketed into when there are multiple experiments
@wangjoshuah
Copy link
Contributor Author

@optimizely/fullstack-devs

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wangjoshuah wangjoshuah merged commit 9acfab2 into master Aug 8, 2017
@wangjoshuah wangjoshuah deleted the josh.wang/feature_variable_accessor_with_type branch August 8, 2017 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants