Skip to content

feature flag parsing #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 27, 2017
Merged

feature flag parsing #130

merged 12 commits into from
Jul 27, 2017

Conversation

wangjoshuah
Copy link
Contributor

@optimizely/fullstack-devs

…e ProjectConfigParsing evaluation.

Update the v4 datafile with an empty top level "variables" array and added "status" to all variables in features.
Added empty array passed in to ProjectConfig constructor in ValidProjectConfigV4.java
ProjectConfigTestUtils now compare feature flags more effectively

Signed-off-by: wangjoshuah <wangjoshuah@gmail.com>
Fix GsonParsing of FeatureFlags
Fix org.Json ProjectConfig parsing

Signed-off-by: wangjoshuah <wangjoshuah@gmail.com>
Fix JsonSimple ProjectConfig parsing

Signed-off-by: wangjoshuah <wangjoshuah@gmail.com>
@wangjoshuah wangjoshuah force-pushed the josh.wang/feature_flag_parsing branch from baa8207 to 88e972c Compare July 26, 2017 20:21
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangjoshuah wangjoshuah merged commit ad49a4a into master Jul 27, 2017
@wangjoshuah wangjoshuah deleted the josh.wang/feature_flag_parsing branch July 27, 2017 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants