[AI-FSSDK] (DO NOT REVIEW) [FSSDK-12275] Skip unsupported experiment type during flag decision#438
Open
[AI-FSSDK] (DO NOT REVIEW) [FSSDK-12275] Skip unsupported experiment type during flag decision#438
Conversation
… during flag decision - Add Type field to Experiment struct in entities/experiment.go - Define supportedExperimentTypes map with values: a/b, mab, cmab, feature_rollouts - Update FeatureExperimentService.GetDecision to check experiment types - Skip evaluation only if Type is non-empty but not in supported list - Evaluate normally if Type is empty or is supported - Add comprehensive unit tests covering all scenarios Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements experiment type filtering in the feature experiment service to skip unsupported experiment types during flag decision evaluation.
Changes
Typefield to theExperimentstruct inpkg/entities/experiment.gosupportedExperimentTypesmap with values:a/b,mab,cmab,feature_rolloutsFeatureExperimentService.GetDecisionto:Implementation Details
The feature experiment service now checks the experiment
Typefield during flag decision:Typeis empty string: Experiment is evaluated (backward compatible)Typeis in supported map: Experiment is evaluatedTypeis non-empty but NOT in supported map: Experiment is skipped with debug logThis ensures the SDK can gracefully handle new experiment types introduced in the datafile without breaking existing functionality.
Test Plan
Related
🤖 Generated with Claude Code