Skip to content

fix(framework): Deprecating old frameworks. #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 27, 2019
Merged

fix(framework): Deprecating old frameworks. #195

merged 2 commits into from
Aug 27, 2019

Conversation

msohailhussain
Copy link
Contributor

Summary

  • added warning for 3.5 framework and .net standard 1.6
  • Added proper separate constants for .net framework 4.0 and 3.5.
  • Updated unit tests as well

Test plan

  • Unit tests modified.

@msohailhussain
- corrected project constants
30d92de 
- added warning for 3.5 and 1.6 NS
@msohailhussain msohailhussain requested a review from a team as a code owner August 22, 2019 07:24
@msohailhussain msohailhussain mentioned this pull request Aug 22, 2019
Merged
mikeproeng37
mikeproeng37 approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 03261a7 into master Aug 27, 2019
@msohailhussain msohailhussain deleted the sohail/cleanup branch September 24, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees

@msohailhussain msohailhussain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msohailhussain @mikeproeng37 @mnoman09