Skip to content

[FSSDK-9432] fix: fix to support arbitrary client names to be included in logx and odp events. #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Jun 16, 2023

Summary

Fix to support arbitrary client names to be included in logx and odp events.
This fix depends on the change in the java-sdk core (optimizely/java-sdk#524)

Test plan

Add unit tests for new APIs.
Pass all existing tests.

Issues

  • FSSDK-9432

Copy link
Contributor

@mnoman09 mnoman09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muzahidul-opti muzahidul-opti merged commit 52f5f6d into master Aug 31, 2023
@muzahidul-opti muzahidul-opti deleted the jae/client-name branch August 31, 2023 14:01
muzahidul-opti added a commit that referenced this pull request Sep 1, 2023
… included in logx and odp events. (#459)"

This reverts commit 52f5f6d.
@muzahidul-opti muzahidul-opti restored the jae/client-name branch September 2, 2023 00:09
muzahidul-opti added a commit that referenced this pull request Sep 20, 2023
… included in logx and odp events. (#459)" (#466)

This reverts commit 52f5f6d.
jaeopt added a commit that referenced this pull request Jan 16, 2024
…es to be included in logx and odp events. (#459)" (#466)"

This reverts commit 21883e3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants