Skip to content

fix: add line so test-app does not abort on lint errors #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2020
Merged

fix: add line so test-app does not abort on lint errors #354

merged 1 commit into from
Dec 4, 2020

Conversation

thomaszurkan-optimizely
Copy link
Contributor

Summary

  • fresh builds will fail with lint errors in test-app. suppress abort on failure.

@thomaszurkan-optimizely thomaszurkan-optimizely requested a review from a team as a code owner December 4, 2020 21:48
Mat001
Mat001 approved these changes Dec 4, 2020
View reviewed changes
Copy link

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mat001
Copy link

Mat001 commented Dec 4, 2020

@thomaszurkan-optimizely looks like yu have some training spaces. Trvis failed the PR build

@jaeopt jaeopt merged commit 71edae3 into master Dec 4, 2020
@jaeopt jaeopt deleted the fixTestAppLint branch December 4, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mat001 Mat001 Mat001 approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees

@thomaszurkan-optimizely thomaszurkan-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomaszurkan-optimizely @Mat001 @jaeopt