Skip to content

Source Clear Improvements #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2018
Merged

Source Clear Improvements #220

merged 1 commit into from
Aug 15, 2018

Conversation

shihpatrick
Copy link
Contributor

Summary

All recommended package upgrades from Source Clear does not break the current code base.

Testing

  • ./gradlew assemble successfully built
  • ./gradlew testAllModule passed
  • ./gradlew testAllModulesTravis passed
  • test-app passed
    • Used the test app and configured it to my own experiment. I used the test app as if I were a user, and then checked the results page to see if the functionality of Optimizely on the test app still worked.

thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Aug 15, 2018
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 1e6f871 into master Aug 15, 2018
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the pshih/source-clear-improvements branch August 15, 2018 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

@aliabbasrizvi aliabbasrizvi Awaiting requested review from aliabbasrizvi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shihpatrick @thomaszurkan-optimizely @patrickshih-optimizely