Skip to content

fix deploy #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 8, 2018
Merged

fix deploy #217

merged 16 commits into from
Aug 8, 2018

Conversation

thomaszurkan-optimizely
Copy link
Contributor

No description provided.

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have a few small questions. Also, should we be testing on APIs 27 and 28 as well?

android:
components:
- tools
- platform-tools
- tools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed twice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently, it is a travis thing:
https://docs.travis-ci.com/user/languages/android/

.travis.yml Outdated
@@ -2,14 +2,17 @@ language: android
env:
global:
# These parameters should match the parameters for build tools and sdk versions in the gradle file
- ANDROID_API=26
- EMULATOR_API=21
# - ANDROID_API=26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we delete this comment?

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 80a89c8 into master Aug 8, 2018
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the fix/travis/deploy branch August 8, 2018 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants