-
Notifications
You must be signed in to change notification settings - Fork 38
fix deploy #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix deploy #217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just have a few small questions. Also, should we be testing on APIs 27 and 28 as well?
android: | ||
components: | ||
- tools | ||
- platform-tools | ||
- tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apparently, it is a travis thing:
https://docs.travis-ci.com/user/languages/android/
.travis.yml
Outdated
@@ -2,14 +2,17 @@ language: android | |||
env: | |||
global: | |||
# These parameters should match the parameters for build tools and sdk versions in the gradle file | |||
- ANDROID_API=26 | |||
- EMULATOR_API=21 | |||
# - ANDROID_API=26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we delete this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.