Skip to content

fix(tests): Fixing acceptance tests and coveralls. #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 20, 2022
Merged

fix(tests): Fixing acceptance tests and coveralls. #352

merged 7 commits into from
Dec 20, 2022

Conversation

yasirfolio3
Copy link
Contributor

@yasirfolio3 yasirfolio3 commented Dec 20, 2022 •
edited
Loading

Summary

  • Fixes acceptance tests and coveralls.

Tests

  • All tests should pass

@yasirfolio3 yasirfolio3 changed the title [TEST PR]: Fixing acceptance tests and coveralls. fix(tests): Fixing acceptance tests and coveralls. Dec 20, 2022
@yasirfolio3 yasirfolio3 marked this pull request as ready for review December 20, 2022 08:34
msohailhussain
msohailhussain approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msohailhussain msohailhussain merged commit 57e63d9 into master Dec 20, 2022
@msohailhussain msohailhussain deleted the yasir/fix-tests branch December 20, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msohailhussain msohailhussain msohailhussain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yasirfolio3 @msohailhussain