Skip to content

[docs] adding versioned docs to travis; update v4.0 markdown docs for Raptor/Decide release #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 15, 2021
Merged

[docs] adding versioned docs to travis; update v4.0 markdown docs for Raptor/Decide release #296

merged 12 commits into from
Apr 15, 2021

Conversation

fscelliott
Copy link
Contributor

@fscelliott fscelliott commented Jan 18, 2021 •
edited
Loading

Summary

For the Decide API and Raptor releases:

  • introduced versioning to the docs
  • updated the terminology + added decide call to docs (see especially this commit for a diff: c937c98 )
    OTHER NOTES for reviewers:
  • the openapi spec will also need to be updated!
  • I don't read GO super well so please review my docs carefully in c937c98; I may have made errors, I was just going off looking at the Decide PR diffs.
  • I don't know if the /datafile endpoint is also going to be part of the Decide release but if so it will also need docs/openapi updates!

Issues

@fscelliott fscelliott changed the title adding versioned docs infrastructure [docs] adding versioned docs to travis; update v4.0 docs for Raptor/Decide Jan 19, 2021
@fscelliott fscelliott changed the title [docs] adding versioned docs to travis; update v4.0 docs for Raptor/Decide [docs] adding versioned docs to travis Jan 19, 2021
@fscelliott fscelliott changed the title [docs] adding versioned docs to travis [docs] adding versioned docs to travis; update v4.0 markdown docs for Raptor/Decide release Jan 19, 2021
@fscelliott
clean diff v3.1 vs 4.0 docs
c937c98 
raptor & decide terminology/endpoint update
@fscelliott
undo test ordering of stages
5436c4d
@fscelliott fscelliott requested a review from mjc1283 January 25, 2021 20:56
@fscelliott fscelliott mentioned this pull request Mar 1, 2021
Closed
yasirfolio3
yasirfolio3 suggested changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@yasirfolio3 yasirfolio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, have made some minor comments.

Mat001
Mat001 requested changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fscelliott Out of curiosity, changes to these examples are not included in this PR: https://github.com/optimizely/agent/tree/master/examples ?
I don't see the changes, except to authentication. Are they not supposed to be part of this PR?

@fscelliott fscelliott requested review from yasirfolio3 and Mat001 and removed request for mjc1283 March 15, 2021 22:00
@fscelliott fscelliott requested review from yasirfolio3 and removed request for yasirfolio3 March 23, 2021 18:05
yasirfolio3
yasirfolio3 approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@yasirfolio3 yasirfolio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fscelliott fscelliott merged commit e0d4d31 into master Apr 15, 2021
@fscelliott fscelliott deleted the docs-decide branch April 15, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mat001 Mat001 Mat001 approved these changes

@yasirfolio3 yasirfolio3 yasirfolio3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fscelliott @Mat001 @yasirfolio3