-
Notifications
You must be signed in to change notification settings - Fork 27
Docs api #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs api #208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple comments:
-sorry, is there a prettifier or something I should run to avoid the long lines I've created here?
- don't quite get the JWT endpoint --- where are you configuring expiration/sdk? is it reflected in the datafile? Is "Optimizely config" endpoint a subset of the datafile, or the datafile itself...?
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
=======================================
Coverage 82.27% 82.27%
=======================================
Files 27 27
Lines 1241 1241
=======================================
Hits 1021 1021
Misses 165 165
Partials 55 55 Continue to review full report at Codecov.
|
Co-Authored-By: JC <40373238+juancarlostong@users.noreply.github.com>
@juancarlostong I merged your suggestion. Are you ready to approve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Summary
Issues