feat: add option to disable safe html #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jurienhamaker Sounds nice. Thanks for the maintenance. I'll be able to check it out next week. |
|
@jurienhamaker Released https://github.com/optimistex/ngx-select-ex/releases/tag/v6.1.0 Thanks again for the maintain! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because all
textis automatically marked as safe html, user input is now vulnerable to XSS attacks on other users. Therefore I added the option to disable the sanitization in thesanitize()function if neededPlease merge and deploy this asap as this is a huge security risk.
Personally I would opt for it to be disabled by default and enabled by the developer if needed, but that would require a major version.