Skip to content

Add pre-commit hook that checks mypy version consistency #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 16, 2025

Conversation

timmens
Copy link
Member

@timmens timmens commented Jul 11, 2025

In this PR we add a local pre-commit hook that checks whether the mypy version in the pre-commit config and the (conda) environment are the same.

This is supposed to help us keep these two versions the same, as otherwise we cannot ensure consistent results of calling mypy.

Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timmens timmens requested a review from janosg July 11, 2025 14:03
Copy link
Member

@janosg janosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! I like that we just flag the problem so we can decide ourselves how to fix it.

@janosg janosg merged commit cb91481 into main Jul 16, 2025
23 checks passed
@janosg janosg deleted the align-mypy-version branch July 16, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants