bitpit: miscellaneous coverity fixes #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardolombardi
approved these changes
Oct 22, 2020
marcocisternino
approved these changes
Oct 23, 2020
Fixes an error reported by Coverity: "sign_extension: Suspicious implicit sign extension: this->m_dimensions with type uint8_t (8 bits, unsigned) is promoted in this->m_dimensions * nCoeffs to type int (32 bits, signed), then sign-extended to type unsigned long (64 bits, unsigned). If this->m_dimensions * nCoeffs is greater than 0x7FFFFFFF, the upper bits of the result will all be 1".
…overflow Fixes an error reported by Coverity: "overflow_before_widen: Applying the unary minus operator to dh of type uint32_t and assigning the result to coord[2UL] of type std::array<long, 3ul>::value_type could produce an unintended large positive integer".
andrea-iob
force-pushed
the
coverity.fixes
branch
from
1c7b504
to
d5de4fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for errors found by Coverity.