-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PABLO: optimize refinement #88
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the code of every commit and it seems correct to me. Has someone tested the pull request? Do tests pass? Do applications tests pass? We should have some test checking the results somehow...
I've tested the changes with our CFD solver and all bitpit tests pass. |
andrea-iob
force-pushed
the
PABLO.optimize.refinement
branch
2 times, most recently
from
September 26, 2020 06:03
cbe4904
to
48790e4
Compare
edoardolombardi
approved these changes
Nov 4, 2020
andrea-iob
force-pushed
the
PABLO.optimize.refinement
branch
from
November 9, 2020 11:13
48790e4
to
18c3cbe
Compare
marcocisternino
approved these changes
Dec 23, 2020
An octant at its maximum refinement level has no children.
The function will build the children directly on the storage space provided in input.
andrea-iob
force-pushed
the
PABLO.optimize.refinement
branch
from
December 23, 2020 20:20
18c3cbe
to
0faf2bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to avoid unneeded allocations.