Fix voloctree mapper

[edoardolombardi]

Fix inverse mapping re-communication

[andrea-iob]

Changes to the .gitignore file doesn't belong to this pull request.

Mapping info can be large, can we avoid making the copy? Something along the lines with (not tested):

            // Remove old ids and ranks if rank != from local one
            auto infoItr = info.begin();
            while (infoItr != info.end()) {
                int rank = infoItr->ranks[i];
                if (rank != m_mappedPatch->getRank()){
                    infoItr = info.erase(infoItr);
                } else {
                    ++infoItr;
                }
            }

[edoardolombardi]

Your proposal is not aligned with the code; erasing a whole info item is not an option here.
I pushed a new implementation without copy.

[andrea-iob]

I don't fully understand the updated code; I don't see were the iterators are updated when you are deleting an entry. I would expect something like the following:

            auto idsIter = info.ids.begin();
            auto ranksIter = info.ranks.begin();
            while (idsIter != info.ids.end()){
                int rank = *ranksIter;
                if (rank != m_mappedPatch->getRank()){
                    idsIter = info.ids.erase(idsIter);
                    ranksIter = info.ranks.erase(ranksIter);
                }
                else{
                    idsIter++;
                    ranksIter++;
                }
            }

Anyways, I haven't look at what the code does except for the small portion changed by the patch, so if your code is tested and works that's fine with me. Also, if you are deleting single entries in a vector, you original code my be faster (I thought you were deleting the whole vectors).

[edoardolombardi]

Ah, you're right, thanks. I'm pushing the fixed version.
I don't have any preferences between using the original version or this one. For our sample cases differences in time or memory are not appreciable.

[andrea-iob]

I've split the changes in two commits and updated the coding style. I will merge as soon as the tests finish.