LA: optimize system update #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-iob
force-pushed
the
LA.optimize.system.update
branch
from
2baa7ba
to
7154e7d
Compare
andrea-iob
force-pushed
the
LA.optimize.system.update
branch
from
7154e7d
to
39dc186
Compare
marcocisternino
approved these changes
Jun 25, 2020
andrea-iob
force-pushed
the
LA.optimize.system.update
branch
from
39dc186
to
6e33cca
Compare
… added during update
andrea-iob
force-pushed
the
LA.optimize.system.update
branch
from
6e33cca
to
5e17d69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System update can alter only the values of the matrix, not its pattern. Instead of coding our own check that enforces this condition, it is simpler and much cheaper to set the "MAT_NEW_NONZERO_LOCATIONS" PETSc option to false after the first matrix assembly. This ensures no new non-zero entries can be added during system updates.
This banche starts from "discretization.update.all", the commit that implements this optimization is the last one in the series.