Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitpit: fixes for some misusage related to references #59

Merged
merged 25 commits into from
Apr 9, 2020
Merged

bitpit: fixes for some misusage related to references #59

merged 25 commits into from
Apr 9, 2020

Conversation

andrea-iob
Copy link
Member

Fixes the following type of misusages of references:

  • small and trivially-copyable types passed by reference;
  • large types passed by value;
  • usage of copies in for-range loops.

roccoarpa
roccoarpa reviewed Mar 30, 2020
View reviewed changes
Copy link
Contributor

@roccoarpa roccoarpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is ok for me

@andrea-iob
Copy link
Member Author

I fixed the commit message for the IO/DGF changes and checked that the the dump of a PiercedStorage of bools works as expected.

@andrea-iob
Copy link
Member Author

Can I merge this changes to the master branch?

@edoardolombardi edoardolombardi self-requested a review April 7, 2020 11:13
@andrea-iob
containers: pass small and trivially-copyable types by value
9f3bac5
@andrea-iob
LA: use constant reference in range-based for loops
8a37973
@andrea-iob
CG: pass small and trivially-copyable types by value
0438844
@andrea-iob
CG: function 'computeGeneralizedBarycentric' has no return value
7e6ce08
@andrea-iob
IO/DGF: pass large types by constant reference
3c2b250
@andrea-iob
IO/VTK: pass small and trivially-copyable types by value
21c4613
@andrea-iob
IO/VTK: pass large types by constant reference
09aa90e
@andrea-iob
IO/logger: pass large types by constant reference
9b2b05e
@andrea-iob
PABLO: pass small and trivially-copyable types by value
ccf7ccb
@andrea-iob
PABLO: pass large types by constant reference
6a16db5
@andrea-iob
RBF: pass small and trivially-copyable types by value
332ee85
@andrea-iob
test/RBF: pass large types by constant reference
f0e13a2
@andrea-iob
patchkernel: pass large types by constant reference
a08598f
@andrea-iob
patchkernel: use constant reference in range-based for loops
0437528
@andrea-iob
patchkernel: function 'evalCellBoundingBox' has not return value
2df8aa7
@andrea-iob
patchkernel: function 'evalInterfaceBoundingBox' has not return value
a8e1efb
@andrea-iob
volcartesian: pass small and trivially-copyable types by value
c997fe5
@andrea-iob
voloctree: pass large types by constant reference
45476c6
@andrea-iob
examples/voloctree: use constant reference in range-based for loops
dd46038
@andrea-iob andrea-iob merged commit bc47098 into master Apr 9, 2020
@andrea-iob andrea-iob deleted the bitpit.fix.references branch April 9, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roccoarpa roccoarpa roccoarpa left review comments

@edoardolombardi edoardolombardi edoardolombardi approved these changes

@haysam haysam Awaiting requested review from haysam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrea-iob @edoardolombardi @roccoarpa