240501.215410.HKT remove the env variables in the matrix of cmake.yml…

…, as they are not supported as of today
opt4ai · May 1, 2024 · a8c953e · a8c953e
1 parent ca1145b
commit a8c953e
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 5 deletions.
diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml
@@ -26,6 +26,9 @@ permissions:
 
 jobs:
 
+  # N.B.: It is tempting to use environment variables to define the compiler flags to avoid
+  # repeating them, but this is not supported as of 20240501. See
+  # https://stackoverflow.com/questions/74072206/github-actions-use-variables-in-matrix-definition
   cmake-main:
     runs-on: ${{ matrix.os }}
     continue-on-error: true
@@ -148,7 +151,7 @@ jobs:
           cmake --version
 
           VERBOSE_MAKEFILE=OFF
-          if [[ ${{ github.event.inputs.verbose-makefile }} == 'true' ]] ; then
+          if [[ "${{ github.event.inputs.verbose-makefile }}" == "true" ]] ; then
               VERBOSE_MAKEFILE=ON
           fi
 

diff --git a/.github/workflows/cmake_mac.yml b/.github/workflows/cmake_mac.yml
@@ -79,7 +79,7 @@ jobs:
           cmake --version
 
           VERBOSE_MAKEFILE=OFF
-          if [[ ${{ github.event.inputs.verbose-makefile }} == 'true' ]] ; then
+          if [[ "${{ github.event.inputs.verbose-makefile }}" == "true" ]] ; then
               VERBOSE_MAKEFILE=ON
           fi
 

diff --git a/.github/workflows/cmake_mac_nagfor.yml b/.github/workflows/cmake_mac_nagfor.yml
@@ -79,7 +79,7 @@ jobs:
           cmake --version
 
           VERBOSE_MAKEFILE=OFF
-          if [[ ${{ github.event.inputs.verbose-makefile }} == 'true' ]] ; then
+          if [[ "${{ github.event.inputs.verbose-makefile }}" == "true" ]] ; then
               VERBOSE_MAKEFILE=ON
           fi
 

diff --git a/.github/workflows/cmake_nagfor.yml b/.github/workflows/cmake_nagfor.yml
@@ -76,7 +76,7 @@ jobs:
           cmake --version
 
           VERBOSE_MAKEFILE=OFF
-          if [[ ${{ github.event.inputs.verbose-makefile }} == 'true' ]] ; then
+          if [[ "${{ github.event.inputs.verbose-makefile }}" == "true" ]] ; then
               VERBOSE_MAKEFILE=ON
           fi
 

diff --git a/.github/workflows/cmake_pi.yml b/.github/workflows/cmake_pi.yml
@@ -74,7 +74,7 @@ jobs:
           cmake --version
 
           VERBOSE_MAKEFILE=OFF
-          if [[ ${{ github.event.inputs.verbose-makefile }} == 'true' ]] ; then
+          if [[ "${{ github.event.inputs.verbose-makefile }}" == "true" ]] ; then
               VERBOSE_MAKEFILE=ON
           fi