This repository has been archived by the owner on Nov 21, 2022. It is now read-only.
#decouple content script #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- modified existing checkTweetListObserver to watch over tweetList and not root in order to further specify it
ribicn-softerrific
changed the title
djbusstop
approved these changes
Feb 20, 2020
djbusstop
approved these changes
Feb 20, 2020
cmcaine
added a commit
to cmcaine/ignore
that referenced
this pull request
Feb 25, 2020
Twitter is served as a SPA, so it is not safe to remove our root observer after finding the first tweet list element. When the user browses to a new page the tweet list element on page 1 may not be the same as the element on page 2. I've restored the old listener from pre-opt-out-tools#96 with small changes to accommodate the new API.
cmcaine
reviewed
Feb 25, 2020
| option = message.selector; | ||
| slider = message.slider; | ||
| browser.runtime.onMessage.addListener((popupSettings) => { | ||
| if (popupPrefs !== popupSettings) { |
There was a problem hiding this comment.
I think these objects will always have different identities, even if their content is the same.
| }; | ||
| const bodyColor = window.getComputedStyle(document.body, null).getPropertyValue('background-color'); | ||
| const root = document.getElementById(SELECTOR_OFFLINE_ROOT) || document.getElementById(SELECTOR_ONLINE_ROOT); | ||
| const tweetSelector = (document.querySelector('body').classList.contains('logged-out')) ? SELECTOR_OFFLINE_TWEET : SELECTOR_ONLINE_TWEET; |
There was a problem hiding this comment.
Shouldn't these be in CAPS?
| }); | ||
| } else { | ||
| console.log('Failed response: ', response); | ||
| const checkTweetListCreation = new MutationObserver( |
There was a problem hiding this comment.
Twitter is served as a SPA, so this is not safe: the tweet list element on page 1 may not be the same as the element on page 2, but we'll have already removed our observer.
There was a problem hiding this comment.
I've fixed this in pr #100.
malteserteresa
pushed a commit
that referenced
this pull request
Feb 26, 2020
Fix: PR #96 removed our observer overly eagerly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decoupled script, merged previous changes, updated observers and selectors