Skip to content

Conversation

@ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Feb 4, 2026

Upgrade ty and also add some additional ignore lines due to conflicts between ty and mypy at the moment.

Summary by CodeRabbit

  • Chores
    • Updated internal development tooling configuration and dependencies.

@coderabbitai
Copy link

coderabbitai bot commented Feb 4, 2026

Walkthrough

This PR updates the project configuration file by bumping the ty linter dependency from version 0.0.8 to 0.0.14. Additionally, it adds two new configuration overrides to the [tool.ty.overrides] section: one for the infrahub_sdk/** path and one for the tests/** path, both setting unused-ignore-comment = "ignore". These overrides are configured to prevent conflicts between ty and mypy type ignore comments.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Upgrade ty' directly and clearly describes the main change—upgrading the ty dependency from 0.0.8 to 0.0.14, which is the primary action in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 376d5dd
Status: ✅  Deploy successful!
Preview URL: https://2e9a4b06.infrahub-sdk-python.pages.dev
Branch Preview URL: https://pog-upgrade-ty.infrahub-sdk-python.pages.dev

View logs

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##           stable     #797   +/-   ##
=======================================
  Coverage   80.36%   80.36%           
=======================================
  Files         115      115           
  Lines        9865     9865           
  Branches     1504     1504           
=======================================
  Hits         7928     7928           
  Misses       1415     1415           
  Partials      522      522           
Flag Coverage Δ
integration-tests 41.41% <ø> (ø)
python-3.10 51.36% <ø> (-0.03%) ⬇️
python-3.11 51.36% <ø> (-0.03%) ⬇️
python-3.12 51.38% <ø> (ø)
python-3.13 51.36% <ø> (-0.03%) ⬇️
python-3.14 53.03% <ø> (+0.02%) ⬆️
python-filler-3.12 24.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogenstad ogenstad marked this pull request as ready for review February 4, 2026 10:36
@ogenstad ogenstad requested a review from a team as a code owner February 4, 2026 10:36
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
pyproject.toml (1)

133-140: ⚠️ Potential issue | 🟡 Minor

Consider narrowing the unused-ignore-comment suppression scope or disabling only for # type: ignore comments.

Suppressing this rule globally disables detection of stale ignore comments across the codebase. ty does not offer a mypy-compat mode, but you can use analysis.respect-type-ignore-comments = false to prevent ty from treating # type: ignore comments as suppression (useful if mypy is also in use). Otherwise, narrowing the scope via per-rule or per-file configuration would keep the signal without blanket suppression.

@ogenstad ogenstad merged commit 6843891 into stable Feb 4, 2026
21 checks passed
@ogenstad ogenstad deleted the pog-upgrade-ty branch February 4, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants