Skip to content

Conversation

@ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Jan 27, 2026

Summary by CodeRabbit

  • Chores
    • Updated template rendering configuration to improve consistency and predictability in generated output across protocol generation and documentation modules.
    • Refined project-wide linting and code quality configuration with targeted adjustments for specific modules to maintain consistent coding standards.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

Walkthrough

This pull request modifies Jinja2 template rendering configurations and linting rules across the codebase. The infrahub_sdk/protocols_generator/generator.py and tasks.py files both update their Jinja2 environment setup to explicitly disable autoescaping for string output. Additionally, pyproject.toml is updated to remove S701 from global linting ignores and add it as a targeted per-file ignore for infrahub_sdk/template/__init__.py, accompanied by explanatory comments.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: fixing ruff Jinja2 violations (S701) by adding autoescape configuration and moving the remaining warning to a per-file ignore list.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 27, 2026

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 42d7871
Status: ✅  Deploy successful!
Preview URL: https://62ab0aa4.infrahub-sdk-python.pages.dev
Branch Preview URL: https://pog-s701.infrahub-sdk-python.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##           stable     #781   +/-   ##
=======================================
  Coverage   80.37%   80.37%           
=======================================
  Files         115      115           
  Lines        9863     9863           
  Branches     1504     1504           
=======================================
  Hits         7927     7927           
  Misses       1414     1414           
  Partials      522      522           
Flag Coverage Δ
integration-tests 41.42% <0.00%> (ø)
python-3.10 51.39% <100.00%> (ø)
python-3.11 51.37% <100.00%> (ø)
python-3.12 51.39% <100.00%> (+0.02%) ⬆️
python-3.13 51.39% <100.00%> (+0.02%) ⬆️
python-3.14 53.04% <100.00%> (ø)
python-filler-3.12 24.06% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/protocols_generator/generator.py 95.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogenstad ogenstad marked this pull request as ready for review January 28, 2026 07:44
@ogenstad ogenstad requested a review from a team as a code owner January 28, 2026 07:44
@ogenstad ogenstad merged commit 296c34a into stable Jan 28, 2026
21 checks passed
@ogenstad ogenstad deleted the pog-S701 branch January 28, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants