Skip to content

Conversation

@ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Jan 27, 2026

Summary by CodeRabbit

  • Chores
    • Tightened linting rules by removing broad global ignores and enabling stricter checks globally.
    • Added targeted per-file exemptions for a few new modules to suppress a specific lint rule.
    • No functional, behavioral, or public API changes; purely configuration adjustments to analysis tooling.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

Walkthrough

Global ignores for PLR0912 and PLW0603 were removed from pyproject.toml, enabling those rules project-wide. Per-file ignore blocks were added to suppress PLR0912 in infrahub\_sdk/node/node.py, infrahub\_sdk/node/related\_node.py, infrahub\_sdk/spec/object.py, and infrahub\_sdk/transfer/importer/json.py. Per-file-ignores were also updated to include the two node modules. No functional logic or public API signatures were changed.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Move rules for too many branches' is directly related to the main change: refactoring PLR0912 (too many branches) linting rule suppression from global to per-file ignores in pyproject.toml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 27, 2026

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5aa7e40
Status: ✅  Deploy successful!
Preview URL: https://c82d0c13.infrahub-sdk-python.pages.dev
Branch Preview URL: https://pog-too-many-branches.infrahub-sdk-python.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##           stable     #779   +/-   ##
=======================================
  Coverage   80.36%   80.36%           
=======================================
  Files         115      115           
  Lines        9865     9865           
  Branches     1504     1504           
=======================================
  Hits         7928     7928           
  Misses       1415     1415           
  Partials      522      522           
Flag Coverage Δ
integration-tests 41.41% <ø> (ø)
python-3.10 51.36% <ø> (-0.03%) ⬇️
python-3.11 51.38% <ø> (ø)
python-3.12 51.38% <ø> (ø)
python-3.13 51.38% <ø> (ø)
python-3.14 53.03% <ø> (ø)
python-filler-3.12 24.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogenstad ogenstad marked this pull request as ready for review January 28, 2026 07:45
@ogenstad ogenstad requested a review from a team as a code owner January 28, 2026 07:45
@ogenstad ogenstad force-pushed the pog-too-many-branches branch from ee0e51d to 5aa7e40 Compare January 28, 2026 09:08
@ogenstad ogenstad merged commit be07068 into stable Jan 28, 2026
21 checks passed
@ogenstad ogenstad deleted the pog-too-many-branches branch January 28, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants