You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request refactors dictionary iteration patterns across multiple files. In infrahub_sdk/operation.py, the process_nodes function is modified to iterate over data.items() and access edge data through the per-kind variable. In infrahub_sdk/utils.py, the deep merge utility is updated to use .items() for iteration, and calculate_dict_height is refactored to iterate over data.values(). The linter rule PLC0206 is removed from pyproject.toml to enforce these patterns. A new public function calculate_dict_height is added to the utils module with corresponding unit tests.
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.
Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name
Status
Explanation
Description Check
✅ Passed
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
✅ Passed
The title accurately describes the main change: fixing dictionary value extraction patterns to use .items() where appropriate, which is confirmed by the pyproject.toml removal of PLC0206 linter rule and corresponding fixes in operation.py and utils.py.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor linting cleanup.
Summary by CodeRabbit
New Features
calculate_dict_heightutility function for public use.Bug Fixes
Tests
Chores
✏️ Tip: You can customize this high-level summary in your review settings.