Various housekeeping tasks #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying infrahub-sdk-python with
|
| Latest commit: |
e40d942
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a5cbe7ac.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://dga-20250413-housekeeping.infrahub-sdk-python.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #354 +/- ##
========================================
Coverage 72.45% 72.45%
========================================
Files 91 91
Lines 8180 8180
Branches 1576 1576
========================================
Hits 5927 5927
Misses 1841 1841
Partials 412 412
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ogenstad
approved these changes
Apr 14, 2025
|
|
||
| for name in ENV_VARS_TO_CLEAN: | ||
| if original_values[name] is not None: | ||
| os.environ[name] = original_values[name] |
There was a problem hiding this comment.
Given that this will run until the session has completed I don't know if there's a point of resetting the environment variables after everything has completed. There should be nothing left that would use them at that point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest-httpxand set all responses as reusable (required by the latest version of pytest-httpxmetadatain InfrahubFileData