Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to customize the API backoff mechanism #296

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

iuriaranda
Copy link
Contributor

This makes the backoff mechanism customizable via the following new options in the provider configuration:

api_retry_count
api_retry_wait_min
api_retry_wait_max

As per #268

This makes the backoff mechanism customizable via the following new options in the provider configuration:

api_retry_count
api_retry_wait_min
api_retry_wait_max

As per opsgenie#268
duboisph
duboisph previously approved these changes Apr 20, 2022
Copy link

@duboisph duboisph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but I guess that's for the maintainers to decide 🙂

Added by accident...
@iuriaranda
Copy link
Contributor Author

hey @koushik-swaminathan , any chance you could give a look at this PR? 🙏

We've been using our fork (this PR) to overcome Opsgenie's rate-limiting for more than a year now, and it's been working good. I think it would be very helpful for users to have the ability to configure the back-off mechanism in the official provider, specially considering that #268 was closed unresolved.

Let me know if there's anything I still need to take care of to be able to merge the PR.

Thanks!

@koushik-swaminathan
Copy link
Contributor

Hi @iuriaranda, I will merge it today :)

Copy link
Contributor

@koushik-swaminathan koushik-swaminathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koushik-swaminathan koushik-swaminathan merged commit 67be33b into opsgenie:master Dec 20, 2023
1 check passed
@iuriaranda iuriaranda deleted the custom-backoff branch December 20, 2023 09:40
@iuriaranda iuriaranda restored the custom-backoff branch December 20, 2023 09:40
@duboisph duboisph deleted the custom-backoff branch December 20, 2023 13:42
@duboisph
Copy link

duboisph commented Feb 1, 2024

Hi @koushik-swaminathan! Do you have an idea when this could be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants