-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to customize the API backoff mechanism #296
Add options to customize the API backoff mechanism #296
Conversation
This makes the backoff mechanism customizable via the following new options in the provider configuration: api_retry_count api_retry_wait_min api_retry_wait_max As per opsgenie#268
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, but I guess that's for the maintainers to decide 🙂
Added by accident...
hey @koushik-swaminathan , any chance you could give a look at this PR? 🙏 We've been using our fork (this PR) to overcome Opsgenie's rate-limiting for more than a year now, and it's been working good. I think it would be very helpful for users to have the ability to configure the back-off mechanism in the official provider, specially considering that #268 was closed unresolved. Let me know if there's anything I still need to take care of to be able to merge the PR. Thanks! |
Hi @iuriaranda, I will merge it today :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @koushik-swaminathan! Do you have an idea when this could be released? |
This makes the backoff mechanism customizable via the following new options in the provider configuration:
api_retry_count
api_retry_wait_min
api_retry_wait_max
As per #268